Skip to content

feat(stackable-operator): Add headless/metrics service name functions to RoleGroupRef #1069

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 9 commits into from
Jul 10, 2025
Merged

feat(stackable-operator): Add headless/metrics service name functions to RoleGroupRef #1069

merged 9 commits into from
Jul 10, 2025
+24 −0

Conversation

Maleware
Copy link
Member

@Maleware Maleware commented Jul 1, 2025

Description

This adds standardised functions to obey https://github.com/stackabletech/decisions/issues/54 consistently across SDP

Definition of Done Checklist

  • Not all of these items are applicable to all PRs, the author should update this template to only leave the boxes in that are relevant
  • Please make sure all these things are done and tick the boxes

Author

  • Changes are OpenShift compatible
  • CRD changes approved
  • CRD documentation for all fields, following the style guide.
  • Integration tests passed (for non trivial changes)
  • Changes need to be "offline" compatible

Reviewer

  • Code contains useful comments
  • Code contains useful logging statements
  • (Integration-)Test cases added
  • Documentation added or updated. Follows the style guide.
  • Changelog updated
  • Cargo.toml only contains references to git tags (not specific commits or branches)

Acceptance

  • Feature Tracker has been updated
  • Proper release label has been added

@Techassi Techassi self-requested a review July 3, 2025 14:05
Techassi
Techassi requested changes Jul 4, 2025
View reviewed changes
@Techassi Techassi moved this to Development: In Review in Stackable Engineering Jul 4, 2025
@Techassi Techassi changed the title Add metrics and headless service name functions to RoleGroupRef feat(stackable-operator): Add rolegroup_{headless,metrics}_service_name functions to RoleGroupRef Jul 4, 2025
@Techassi Techassi changed the title feat(stackable-operator): Add rolegroup_{headless,metrics}_service_name functions to RoleGroupRef feat(stackable-operator): Add headless/metrics service name functions to RoleGroupRef Jul 4, 2025
Techassi
Techassi requested changes Jul 5, 2025
View reviewed changes
Copy link
Member

@Techassi Techassi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, please add a changelog entry for these new functions.

@Maleware
Copy link
Member Author

Maleware commented Jul 9, 2025

Changelog update with 7979a0b

Techassi
Techassi requested changes Jul 9, 2025
View reviewed changes
Copy link
Member

@Techassi Techassi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a small reword, then this is ready to go.

@sbernauer sbernauer enabled auto-merge July 10, 2025 06:44
@sbernauer
Copy link
Member

Merging this to get it in the upcoming release (#1073)

@sbernauer sbernauer requested a review from Techassi July 10, 2025 06:44
@sbernauer sbernauer added this pull request to the merge queue Jul 10, 2025
Merged via the queue into main with commit 9b103e9 Jul 10, 2025
8 checks passed
@sbernauer sbernauer deleted the feature/rolegroup-svc-names branch July 10, 2025 06:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Techassi Techassi Techassi approved these changes

Assignees

@Maleware Maleware

Labels
None yet
Projects
Stackable Engineering
Status: Development: In Review
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Maleware @sbernauer @Techassi